Remove stale PharoCompatibility notice helper dependency#72
Merged
Conversation
Route mutation failure causes through MCP notice dispatch and pass only exception-shaped values to PharoCompatibility compiler AST helpers. Depends on Evref-BL/PharoCompatibility#7 for compiler helper nil contracts. Fixes #71 Co-authored-by: Codex <codex@openai.com>
Member
Author
|
The remaining P14 syntax-classification failures are fixed by PharoCompatibility#8. Local verification after loading that compatibility hook: the four reported P14 MCP failures pass. P12 undeclared-variable compatibility is also covered there; MCP#72 should be rerun after PharoCompatibility#8 is merged. |
Co-authored-by: Codex <codex@openai.com>
Gabriel-Darbord
force-pushed
the
codex/remove-removed-compat-notice-helper
branch
from
7b6f4ea to
52ff7ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PharoCompatibility noticeFromException:ifKindOfAnyNamed:helperDependency
Depends on Evref-BL/PharoCompatibility#7, which restores the compiler-helper nil contract for ordinary exceptions through dispatch hooks.
Verification
With Evref-BL/PharoCompatibility#7 loaded in the P13 image:
MCPToolMethodMutationTest>>#testCompileReturnsStructuredCommandErrorForUndeclaredVariable: passedMCPToolMethodMutationTest: 47 passedFixes #71